Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support constructor parameters annotations for schemes #1417

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Add support constructor parameters annotations for schemes #1417

merged 2 commits into from
Feb 19, 2024

Conversation

altro3
Copy link
Collaborator

@altro3 altro3 commented Feb 4, 2024

No description provided.

@altro3 altro3 changed the title Add support constructor annotations Add support constructor parameters annotations for schemas Feb 4, 2024
@altro3 altro3 changed the title Add support constructor parameters annotations for schemas Add support constructor parameters annotations for schemes Feb 4, 2024
@altro3 altro3 force-pushed the add-support-constructor-annottions branch 3 times, most recently from d6fe83b to 92f31de Compare February 5, 2024 20:15
@CLAassistant
Copy link

CLAassistant commented Feb 7, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@altro3 altro3 force-pushed the add-support-constructor-annottions branch 2 times, most recently from 2ff6b9b to 48d73f0 Compare February 10, 2024 08:53
@altro3 altro3 force-pushed the add-support-constructor-annottions branch from 48d73f0 to f6b153f Compare February 10, 2024 08:54
@altro3 altro3 requested a review from sdelamo February 11, 2024 06:57
@sdelamo
Copy link
Contributor

sdelamo commented Feb 12, 2024

@altro3 you have to sign the CLA again. Sorry for the inconvenience.

@altro3
Copy link
Collaborator Author

altro3 commented Feb 12, 2024

@sdelamo ??? What does it mean? Is this blocking the merge? What do I need to do?

@sdelamo
Copy link
Contributor

sdelamo commented Feb 13, 2024

@sdelamo ??? What does it mean? Is this blocking the merge? What do I need to do?

No action in your side. It appears to be a glitch with cla-assistant.io reporting. Sorry for the noise.

@sdelamo
Copy link
Contributor

sdelamo commented Feb 16, 2024

@altro3 Can you merge master into this branch?

@altro3 altro3 force-pushed the add-support-constructor-annottions branch from f6b153f to 275d11f Compare February 16, 2024 13:44
@altro3
Copy link
Collaborator Author

altro3 commented Feb 16, 2024

@sdelamo done

@altro3 altro3 force-pushed the add-support-constructor-annottions branch from 275d11f to f4c8af0 Compare February 16, 2024 13:49
dstepanov
dstepanov requested changes Feb 16, 2024
View reviewed changes
...i-generator/src/main/java/io/micronaut/openapi/generator/AbstractMicronautKotlinCodegen.java Outdated
}
}
/*
0 = {LoadedVisitor@8165} "io.micronaut.openapi.visitor.OpenApiGroupInfoVisitor@3d615b2e"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls remove

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

openapi/src/main/java/io/micronaut/openapi/visitor/ElementUtils.java Outdated
|| isIgnoredParameterType(parameter.getType());
}

private static boolean isParamAnnotationPresent(Element element, String className) {
return element.findAnnotation(className).isPresent();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not hasAnnotation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstepanov ??? What do you mean? How I need to change it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do I need to change it to this:

parameter.isAnnotationPresent("org.springframework.web.bind.annotation.SessionAttribute")

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and what difference between hasAnnotation and isAnnotationPresent ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s better to avoid returning an optional

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I still didn't get it.: Do I need to change something? If so, what should I change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but I think the method that return a boolean is better than the optional

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstepanov ok, I changed it to hasAnnotation. But what difference between hasAnnotation and isAnnotationPresent ?

@altro3 altro3 force-pushed the add-support-constructor-annottions branch from f4c8af0 to 0a99752 Compare February 16, 2024 14:03
@altro3
Copy link
Collaborator Author

altro3 commented Feb 16, 2024

@sdelamo could you merge this last PR and finalize release?

@altro3 altro3 force-pushed the add-support-constructor-annottions branch from 0a99752 to 6690467 Compare February 17, 2024 07:59
@sdelamo
Copy link
Contributor

sdelamo commented Feb 19, 2024

@altro3 can you merge master into this branch?

@altro3 altro3 force-pushed the add-support-constructor-annottions branch from 6690467 to bfddeaf Compare February 19, 2024 13:14
@altro3
Copy link
Collaborator Author

altro3 commented Feb 19, 2024

@sdelamo done

@sdelamo sdelamo merged commit 0ac85ca into micronaut-projects:master Feb 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstepanov dstepanov dstepanov approved these changes

@sdelamo sdelamo Awaiting requested review from sdelamo

Assignees
No one assigned
Labels
None yet
Projects
4.4.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@altro3 @CLAassistant @sdelamo @dstepanov